[FFmpeg-devel] [PATCH] Move sample format definitions from libavcodec to libavcore.

[Michael Niedermayer]

On Thu, Oct 28, 2010 at 04:28:18PM -0700, Stefano Sabatini wrote:
> On date Wednesday 2010-10-27 11:22:43 +0200, Michael Niedermayer encoded:
> > On Mon, Oct 25, 2010 at 08:12:43PM -0700, Stefano Sabatini wrote:
> > > On date Monday 2010-10-25 14:53:59 +0200, Michael Niedermayer encoded:
> > > > On Sun, Oct 24, 2010 at 11:38:20PM -0700, Stefano Sabatini wrote:
> > > > > ---
> > > > >  libavcodec/avcodec.h  |   27 +++++++++++++++------------
> > > > >  libavcore/Makefile    |    1 +
> > > > >  libavcore/samplefmt.h |   35 +++++++++++++++++++++++++++++++++++
> > > > >  3 files changed, 51 insertions(+), 12 deletions(-)
> > > > >  create mode 100644 libavcore/samplefmt.h
> > > [...]
> > > > > --- /dev/null
> > > > > +++ b/libavcore/samplefmt.h
> > > > 
> > > > do we really want a header per enum ?
> > > 
> > > No, I'm also planning to move there these functions from
> > > libavcodec/audioconvert.h (with some renamings):
> > > 
> > > void avcodec_sample_fmt_string(char *buf, int buf_size, int sample_fmt);
> > > const char *avcodec_get_sample_fmt_name(int sample_fmt);
> > > enum SampleFormat avcodec_get_sample_fmt(const char* name);
> > > const char *avcodec_get_channel_name(int channel_id);
> > > int64_t avcodec_get_channel_layout(const char *name);
> > > void avcodec_get_channel_layout_string(char *buf, int buf_size, int nb_channels, int64_t channel_layout);
> > > int64_t avcodec_guess_channel_layout(int nb_channels, enum CodecID codec_id, const char *fmt_name);
> > > int avcodec_channel_layout_num_channels(int64_t channel_layout);
> > > 
> > > suggest a better name for the file or place where to move them.
> > 
> > audio.h maybe?
> 
> Not that I care much about the name, but audio.h seems a bit too
> generic while samplefmt.h is more specific and is symmetric to
> pixfmt.h, which is in my opinion a nice feature.

the channel stuff has nothing to do with sample formats

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101028/4d876792/attachment.pgp>