[FFmpeg-devel] [PATCH] Google WebP support

[Ronald S. Bultje]

Hi,

On Thu, Oct 28, 2010 at 1:17 AM, Pascal Massimino
<pascal.massimino at gmail.com> wrote:
> On Tue, Oct 19, 2010 at 10:34 AM, Pascal Massimino <
> pascal.massimino at gmail.com> wrote:
>
>> Aurelien,
>>
>> On Tue, Oct 19, 2010 at 4:30 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>>
>>> On Mon, Oct 18, 2010 at 07:39:40PM -0700, Pascal Massimino wrote:
>>> > [...]
>>> >
>>> > About the other webpdec.c/webpenc.c: metadata now seem to no longer
>>> works.
>>> > AVMetadataConv have been deprecated just after i finished addiung them.
>>> > Should i come back to manually mapping tag/metadata keys? (pretty much
>>> > like AVMetadataConv was doing?)
>>>
>>> No. It is not deprecated. It has been moved to internal API. So now,
>>> your demuxer has to call ff_metadata_conv() by itself, instead of
>>> exporting the conversion table in AVInputFormat. That's the only change
>>> required.
>>>
>>
>> actually, i don't need to change stream->metadata to use native tag (since
>> i'd need to convert back to generic down the line afterward. And it's just
>> about
>> putting the tags on the wire so i shouldn't change the object's generic tag
>> i'd say).
>> $attached?
>>
>>
> ping? does someone want the webp{enc,dec}.c patch? [ ] yes ? [ ] no

I personally thought that your later img2.c version was much cleaner,
regardless of the few extra ifs. It's smaller and works for -i
bla%02d.webp input strings. What was the reason you didn't continue
that one?

Ronald