[FFmpeg-devel] [PATCH] h264: mark xmm registers as clobbered in h264 qpel sse functions

Ramiro Polla ramiro.polla
Mon Oct 25 18:11:46 CEST 2010


On Mon, Oct 25, 2010 at 1:58 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Mon, Oct 25, 2010 at 11:54 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>> On Mon, Oct 25, 2010 at 10:36 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>> On Mon, Oct 25, 2010 at 7:20 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>>>> Patch attached for this case (and the similar mmx function).
>>>
>>> Can/should ff_pw_5 etc. be "inlined" in the code so it will also work
>>> with PIC on broken compilers?
>>
>> I don't know.
>>
>>> I believe that's done by using MANGLE(ff_pw_5) or so inside the code
>>> where-ever it is used, instead of making it an argument at the end of
>>> the asm code block.
>>
>> It's done somewhere else on this same file, but it works as-is, so I
>> don't think it *has* to be changed.
>
> Fair enough, if it works it's fine with me. We'll see fate @ darwin
> fail if it doesn't. ;-).

Ah, I got the error now =)

New patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264_merge_2.diff
Type: application/octet-stream
Size: 3601 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101025/503a883e/attachment.obj>



More information about the ffmpeg-devel mailing list