[FFmpeg-devel] [PATCH] rtp/rtsp API deprecation...

[Ronald S. Bultje]

Hi,

On Fri, Oct 15, 2010 at 2:14 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> There are some rtp and rtsp API which are deprecated (depending on
> LIBAVFORMAT_VERSION_MAJOR) even though they are declared in headers
> which are not installed (and thus not part of public API) and defined in
> files which are compile conditionally (and thus not part of ABI).
> So IMHO, it makes no sense to try to maintain those deprecated API until
> next major bump. The attached patches just drop those old APIs.
[..]
> Index: libavformat/rtsp.c
> ===================================================================
> --- libavformat/rtsp.c	(revision 25479)
> +++ libavformat/rtsp.c	(working copy)
> @@ -1024,7 +1024,7 @@
>  #endif
>
>          rtp_opened:
> -            port = rtp_get_local_port(rtsp_st->rtp_handle);
> +            port = rtp_get_local_rtp_port(rtsp_st->rtp_handle);
>          have_port:
>              snprintf(transport, sizeof(transport) - 1,
>                       "%s/UDP;", trans_pref);

OK.

> Index: libavformat/avio.h
> ===================================================================
> --- libavformat/avio.h	(revision 25481)
> +++ libavformat/avio.h	(working copy)
> @@ -182,7 +182,6 @@
>  /**
>   * Return the file descriptor associated with this URL. For RTP, this
>   * will return only the RTP file descriptor, not the RTCP file descriptor.
> - * To get both, use rtp_get_file_handles().
>   *
>   * @return the file descriptor associated with this URL, or <0 on error.
>   */

OK.

For the rest, I'm mildly against it for API-stability reasons (at
least old versions of ffplay used it), but can be convinced otherwise.

Ronald