[FFmpeg-devel] [PATCH 6/6] Add rotate90 filter.

Stefano Sabatini stefano.sabatini-lala
Fri Oct 15 16:54:57 CEST 2010


On date Friday 2010-10-15 14:36:35 +0200, Aurelien Jacobs encoded:
> On Fri, Oct 15, 2010 at 01:13:59AM +0200, Stefano Sabatini wrote:
> > ---
> >  doc/filters.texi           |    6 ++
> >  libavfilter/Makefile       |    1 +
> >  libavfilter/allfilters.c   |    1 +
> >  libavfilter/vf_transpose.c |  173 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 181 insertions(+), 0 deletions(-)
> 
> What about moving this code to its own vf_rotate90.c file (and move
> shared code in a shared file) ?

Slightly against this, since it requires more complexity (internal
function declarations) with no gain, also the invert() and transpose()
functions require the same formats, and I cannot see a safe way to
expose the query_formats() function.

Regards.
-- 
FFmpeg = Free and Foolish Meaningful Powered EnGine



More information about the ffmpeg-devel mailing list