[FFmpeg-devel] [PATCH 3/3] Export metadata in the generic format.

Aurelien Jacobs aurel
Wed Oct 13 14:57:56 CEST 2010


On Wed, Oct 13, 2010 at 12:05:01AM +0200, Michael Niedermayer wrote:
> On Tue, Oct 12, 2010 at 11:54:12PM +0200, Aurelien Jacobs wrote:
> > On Tue, Oct 12, 2010 at 09:37:32PM +0200, Anton Khirnov wrote:
> > > On Tue, Oct 12, 2010 at 09:12:31PM +0200, Michael Niedermayer wrote:
> > > > On Tue, Oct 12, 2010 at 07:35:17PM +0200, Anton Khirnov wrote:
> > > > > On Mon, Oct 11, 2010 at 10:33:21PM +0200, Michael Niedermayer wrote:
> > > > > > On Tue, Oct 05, 2010 at 07:57:06PM +0200, Anton Khirnov wrote:
> [...]
> > > [...]
> > > @@ -152,3 +152,9 @@ void av_metadata_conv(AVFormatContext *ctx, const AVMetadataConv *d_conv,
> > >      for (i=0; i<ctx->nb_programs; i++)
> > >          metadata_conv(&ctx->programs[i]->metadata, d_conv, s_conv);
> > >  }
> > > +
> > > +void av_metadata_conv(AVFormatContext *ctx, const AVMetadataConv *d_conv,
> > > +                                            const AVMetadataConv *s_conv)
> > > +{
> > > +    return;
> > > +}
> > 
> > Should be inside #if FF_API_OLD_METADATA.
> > 
> > Overall, I have a slightly bad feeling about exporting normalized
> > metadata tag instead of the native one, but I don't have any objective
> > reason for this, just a feeling. So if everyone is happy with this, I
> > won't object.
> 
> a objective reason would help alot in solving any problems that such reason
> points to ...

I know. That's why I don't want to hold this patch with nothing more
than a feeling...

> that said we can easily add a flag later or export both normalized and normal
> sets

Having already an easy plan in case my feeling proves right is good
enough for me.

So if the patch is well tested, it should be OK.

Aurel



More information about the ffmpeg-devel mailing list