[FFmpeg-devel] [PATCH 3/3] Export metadata in the generic format.

[Anton Khirnov]

On Tue, Oct 12, 2010 at 09:12:31PM +0200, Michael Niedermayer wrote:
> On Tue, Oct 12, 2010 at 07:35:17PM +0200, Anton Khirnov wrote:
> > On Mon, Oct 11, 2010 at 10:33:21PM +0200, Michael Niedermayer wrote:
> > > On Tue, Oct 05, 2010 at 07:57:06PM +0200, Anton Khirnov wrote:
> > > 
> > > thats a strange place for it one would expect it at the end of the header
> > > reading code
> > > 
> > > 
> > [...]
> > > 
> > > same as asf odd place, there could be multipl info tags
> > > and the same applies to other changes too
> > > 
> > Better now?
> > 
> > I've also removed the conv tables from (de)muxers completely instead of
> > just ifdefing them, since NULL is also a perfeclty valid conv table.
> [...]
> > diff --git a/libavformat/metadata.c b/libavformat/metadata.c
> > index 8fc1771..713304b 100644
> > --- a/libavformat/metadata.c
> > +++ b/libavformat/metadata.c
> > @@ -140,8 +140,8 @@ void metadata_conv(AVMetadata **pm, const AVMetadataConv *d_conv,
> >      *pm = dst;
> >  }
> >  
> > -void av_metadata_conv(AVFormatContext *ctx, const AVMetadataConv *d_conv,
> > -                                            const AVMetadataConv *s_conv)
> > +void metadata_conv_ctx(AVFormatContext *ctx, const AVMetadataConv *d_conv,
> 
> ff_ prefix
done

i guess metadata_conv() should get a ff_ prefix too, i'll send a patch
for this later

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Export-metadata-in-the-generic-format.patch
Type: text/x-diff
Size: 17577 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101012/d3d497fe/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101012/d3d497fe/attachment.pgp>