[FFmpeg-devel] [PATCH] aacenc: Fix coefficient calculation for mid/side.

[Nathan Caldwell]

On Tue, Oct 12, 2010 at 2:51 AM, Alex Converse <alex.converse at gmail.com> wrote:
> On Tue, Oct 5, 2010 at 10:40 PM, Nathan Caldwell <saintdev at gmail.com> wrote:
>> The current code incorrectly subtracts the second channel from the
>> just calculated mid channel. Instead it should be subtracting the
>> second channel from the first.
>
> Just to reiterate what I said on IRC these seem mathematically
> equivalent for well behaved floats. I'd like to see some ABX or other
> testing to prove that this is actually changes anything.
>
> Comments from the peanut gallery welcome.
>
> Thanks,
>
> Alex

Yeah, this doesn't seem to work. I thought it did, and the person
reporting the bug said it did, but when I got their sample there was
no difference between the two.

Retracted.


-- 
-Nathan Caldwell