[FFmpeg-devel] [PATCH] FLAC parser

[Michael Chinen]

Hi,

On Wed, Oct 6, 2010 at 6:50 PM, Justin Ruggles <justin.ruggles at gmail.com> wrote:
> Patch 0001 looks good.
>
> The part of patch 0002 that changes ff_flac_decode_frame_header() to
> return various error codes instead of logging error messages should be a
> separate commit, to be applied after patch 0001.

done.

>
> Unless I'm overlooking something, the actual parser seems missing from
> your patches. ?Did you forget to git add flac_parser.c?

Thanks for catching my mistake!


>
> Patch 0003 seems to be related to more than just your FLAC parser. ?I
> would suggest submitting it for approval in its own thread, along with a
> reiteration of why it is needed.

Yes, I will move that one to its own thread.

>
> Patch 0004 should be included with whatever patch causes those changes.
> ?We shouldn't break seek tests if we can easily avoid it, even if it is
> fixed shortly after.

You're right; it's done.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-move-decode_frame_header-from-flacdec.c-to-flac.c-h.patch
Type: application/octet-stream
Size: 8119 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/f768c348/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-error-codes-for-FLAC-header-parsing-and-move-log.patch
Type: application/octet-stream
Size: 7461 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/f768c348/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-FLAC-Parser.patch
Type: application/octet-stream
Size: 34912 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/f768c348/attachment-0002.obj>