[FFmpeg-devel] [PATCH] rtpdec_svq3: Don't look for the unused RTP_FLAG_KEY flag

[Martin Storsjö]

On Sun, 3 Oct 2010, Josh Allmann wrote:

> On 3 October 2010 07:00, Martin Storsj? <martin at martin.st> wrote:
> > Hi,
> >
> > When looking over some code, I noticed that the svq3 depacketizer looks
> > for the RTP_FLAG_KEY flag in the flags variable, and sets AV_PKT_FLAG_KEY
> > accordingly. However, nothing ever sets the RTP_FLAG_KEY in flags (there's
> > no such bit in a RTP packet, only RTP_FLAG_MARKER is extracted and set),
> > RTP_FLAG_KEY is only used internally within some RDT code and somewhere in
> > the rtpdec_asf code currently.
> >
> > Therefore, these lines of code in rtpdec_svq3 are nothing more than
> > historical cruft/misunderstandings. Decoding still works just fine if this
> > is removed.
> >
> 
> You are right, it is cruft. The patch looks good.

Thanks for the confirmation - applied.

> > Josh, I'm CCing you since I'm not sure if you're still reading this list
> > regularly.
> 
> I still read the lists, even though I may not speak up often :)

Good, good. :-)

> > I checked the wiki docs on this, and it currently says
> >
> > ? ?"the RTP marker bit indicates whether the payload data is a keyframe"
> >
> > which doesn't correspond to what the code currently does, and isn't true.
> > (Currently the RTP marker bit isn't used at all in the code, and I'm not
> > sure exactly what it maps to. In most formats, it indicates end of
> > multi-packet frame, but we have another bit within the payload for that.)
> >
> > So, are you ok with removing this incorrect sentence?
> >
> 
> Yes, I went ahead and updated the wiki entry myself.

Great, thanks!

// Martin