[FFmpeg-devel] [PATCH] mov auto crop

[Benjamin Larsson]

On 10/02/2010 10:03 PM, Baptiste Coudurier wrote:
> On 10/2/10 5:57 AM, Benjamin Larsson wrote:
>> On 10/02/2010 04:51 AM, Baptiste Coudurier wrote:
>>> Hi guys,
>>>
>>> $subject.
>>>
>>> Please keep in mind that this issue has been present for _years_ and
>>> nobody dared to fix it. I believe the patch is not so hackish/ugly.
>>>
>>> I restrict it to codecs not supporting arbitrary resolutions that can be
>>> stored in .mov by quicktime.
>>>
>>> Maybe exporting to "crop", "wxh" is better, I don't know.
>>>
>>> I plan to add auto-rotate for iphone 3gs files this way as well :)
>>>
>>
>> Jolly good. But would it be possible to move this code to the api and
>> just not in the ffmpeg commandline tool? Ie so the users of the api also
>> would get these fixes. Other then that I like the idea.
> 
> I'm not sure I understand. You need to crop after decoding, or you mean
> cropping in the decoder ?
> 

Well now you will get cropping with the commandline tool ffmpeg but not
when using the API. It would be nice if the API could deliver cropped
data. Otherwise everyone who uses the api (mplayer, xbmc, etc) will need
to replicate this in their code, if they wanted to support this.

MvH
Benjamin Larsson