[FFmpeg-devel] [PATCH] Broken metadata conversion for ogg

[Anton Khirnov]

On Sat, Oct 02, 2010 at 09:12:50PM +0200, Aurelien Jacobs wrote:
> On Tue, Sep 28, 2010 at 10:22:21PM +0100, Patrice Bensoussan wrote:
> > Hi,
> > 
> > It seems that the metadata conversion for ogg files has been broken recently. It seems to be caused by a change in oggparsevorbis.c when calling av_metadata_set2(). The patch below to revert the change seems to be fixing the issue, but not sure it's the right way to fix the problem... I assume m variable should be pointing to metadata too?
> 
> It is definitely not the correct way to fix the problem (if there is a
> problem at all!).
I think Patrice is talking about a bug in ffmpeg.c -- it only calls
av_metadata_conv() when copying global metadata. Furthermore it copies
per-stream metadata by default, but doesn't do so for global metadata.
Therefore when dealing with ogg, per-stream metadata is copied but not
converted.

This should be fixed by me stopping procrastinating and finishing the
new conversion API ;)

--
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101002/809126ed/attachment.pgp>