[FFmpeg-devel] [RCF] lavfi aspect ratio setting path

[Stefano Sabatini]

On date Sunday 2010-11-28 14:51:14 -0800, Baptiste Coudurier encoded:
> On 11/28/10 2:41 PM, Stefano Sabatini wrote:
> > On date Wednesday 2010-11-24 00:50:17 -0800, Baptiste Coudurier encoded:
[...]
> >> diff --git a/ffmpeg.c b/ffmpeg.c
> >> index e58e7b5..c85c81b 100644
> >> --- a/ffmpeg.c
> >> +++ b/ffmpeg.c
> >> @@ -351,6 +351,7 @@ static int configure_filters(AVInputStream *ist, AVOutputStream *ost)
> >>      AVCodecContext *codec = ost->st->codec;
> >>      AVCodecContext *icodec = ist->st->codec;
> >>      FFSinkContext ffsink_ctx = { .pix_fmt = codec->pix_fmt };
> >> +    AVRational pixel_aspect_ratio;
> > 
> > I suggest sample_aspect_ratio, for consistency with setsar and
> > AVCodecContext (AVFilterLink.pixel_aspect also should be renamed).
> 
> Humm, ffmpeg displays PAR for it and I think that in this case I would
> prefer naming it pixel_aspect_ratio in AVFilterLink as well.

http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/121220
-- 
FFmpeg = Frightening and Fiendish Meaningless Peaceful Enchanting Guru