[FFmpeg-devel] [patch] yadif code dump

[Ronald S. Bultje]

Hi,

On Sat, Nov 27, 2010 at 3:58 PM, James Darnley <james.darnley at gmail.com> wrote:
> Since I can't duplicate code any more, I put my additions into lavfi, enjoy.
[..]
> -        int is_chroma = !!i;
> -        int w = dstpic->video->w >> is_chroma;
> -        int h = dstpic->video->h >> is_chroma;
> +    for (i = 0; i < yadif->csp->nb_components; i++) {
> +        int w = dstpic->video->w;
> +        int h = dstpic->video->h;
>          int refs = yadif->cur->linesize[i];
>
> +        if (i) {
> +        /* Why is this not part of the per-plane description thing? */
> +            w >>= yadif->csp->log2_chroma_w;
> +            h >>= yadif->csp->log2_chroma_h;
> +        }

w = dstpic->video->w >> (is_chroma * yadif->csp->log2_chroma_w);
h = dstpic->video->h >> (is_chroma * yadif->csp->log2_chroma_h);

I would merge the 16-bit and then factorization, or even inverse it
(i.e. first factorize, then add 16-bit).

Ronald