[FFmpeg-devel] [PATCH] Text subtitle decoder

[Reimar Döffinger]

On Sat, Nov 27, 2010 at 06:16:45PM +0100, Aurelien Jacobs wrote:
> On Sat, Nov 27, 2010 at 09:43:01PM +1100, Peter Ross wrote:
> > +    sub->end_display_time   = pts + 500;
> 
> Why pts + 500 ???
> 
> More generally, what is this decoder useful for ?
> Currently, there are only 3 demuxers which produce CODEC_ID_TEXT streams:
> matroska, nut and ogm.
> For both matroska and ogm this is plain wrong to use CODEC_ID_TEXT, as
> those streams contains in fact SubRip formated text (including some html
> like formatting, like <b>, <font size="20">, etc...).

Note that in addition for ogm the end_display_time definitely is plain wrong,
the subtitle is supposed to be shown until the next (possibly empty) subtitle packet.