[FFmpeg-devel] [PATCH] Implement frei0r source.

Stefano Sabatini stefano.sabatini-lala
Fri Nov 26 00:44:45 CET 2010


On date Thursday 2010-11-25 18:18:16 +0100, Michael Niedermayer encoded:
> On Wed, Nov 24, 2010 at 01:38:10AM +0100, Stefano Sabatini wrote:
> [...]
> 
> > +static int source_request_frame(AVFilterLink *inlink)
> 
> outlink

Fixed.
 
> > +{
> > +    Frei0rContext *frei0r = inlink->src->priv;
> > +    AVFilterBufferRef *picref = avfilter_get_video_buffer(inlink, AV_PERM_WRITE, inlink->w, inlink->h);
> > +    picref->video->pixel_aspect = (AVRational) {1, 1};
> 
> > +    picref->pts = av_rescale_q(frei0r->pts++, frei0r->time_base, inlink->time_base);
> 
> a source filter should never need timestamp rescaling

Fixed.

I also changed the syntax for the frei0r_src, so it now accepts:
frei0r_src=size:rate:name=params

as I found name=params more intuitive (and the old syntax is
supported, if you're OK I'll change the frei0r filter accordingly).

And I'm not sure about the name, frei0r_src is more readable but
frei0rsrc is consistent with nullsrc, opinions?
-- 
FFmpeg = Frenzy and Fancy Multimedia Perennial Exciting Gnome



More information about the ffmpeg-devel mailing list