[FFmpeg-devel] [PATCH 1/4] Implement avfilter_ref_video_buffer().

[Michael Niedermayer]

On Wed, Nov 24, 2010 at 07:20:28PM +0100, Stefano Sabatini wrote:
> On date Wednesday 2010-11-24 17:03:41 +0100, Michael Niedermayer encoded:
> > On Tue, Nov 23, 2010 at 11:23:58PM +0100, Stefano Sabatini wrote:
> > > On date Tuesday 2010-11-23 23:11:46 +0100, Michael Niedermayer encoded:
> > > > On Tue, Nov 23, 2010 at 12:56:33AM +0100, Stefano Sabatini wrote:
[...]
> > > > > This change also requires to make public the
                           ^^^^^^^^^^^^^^^^^^^^^^^

> > > > > avfilter_default_free_buffer() function, as in the attached patch.
> > > > 
> > > > why?
        ^^^^

> > >
> > > I prefer to place the callback for freeing the buffer in the library
> > > code,
> > 
> > my question was "why make it public" not "why in the lib" sorry if that was
> > unclear
> 
> That's completely indifferent to me, and since it is currently
> non-used in application code maybe it's even better to declare them
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

IMHO if its not needed for anything then we should not make it public.
The function pointer comparission bugs we had with the matching function
for AVPacket cant happen if the function is not public ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101125/dca5374a/attachment.pgp>