[FFmpeg-devel] [PATCH] hqdn3d libavfilter port

[Stefano Sabatini]

On date Wednesday 2010-11-24 17:00:19 +0100, Michael Niedermayer encoded:
> On Wed, Nov 24, 2010 at 02:14:06AM +0100, Stefano Sabatini wrote:
> > On date Tuesday 2010-11-23 17:02:15 -0800, Baptiste Coudurier encoded:
> > > On 11/23/2010 03:33 PM, Stefano Sabatini wrote:
> > > >On date Tuesday 2010-11-23 15:25:40 -0800, Baptiste Coudurier encoded:
> > > >>Hi Stefano,
> > > >>
> > > >>On 11/23/2010 10:50 AM, Stefano Sabatini wrote:
> > > >>>On date Monday 2010-11-22 17:42:27 -0800, Baptiste Coudurier encoded:
> > > >>>>On 9/26/10 2:11 AM, Stefano Sabatini wrote:
> > > >>>>>On date Saturday 2010-09-25 17:09:33 -0700, Baptiste Coudurier encoded:
> > > >>>>>>On 9/25/10 4:56 PM, Stefano Sabatini wrote:
> > > >>>>>>>On date Saturday 2010-09-25 16:46:12 -0700, Baptiste Coudurier encoded:
> > > >>>>>>>>On 9/25/10 4:30 PM, Baptiste Coudurier wrote:
> > > >>>>>>>[...]
> > > >>>>>>>>Updated for latest svn.
> > > >>>>>>>>
> > > >>>>>>>>[...]
> > > >>>>>>
> > > >>>>>>Updated.
> > > >>>>>>
> > > >>>>
> > > >>>>Updated patch.
> > > >>>
> > > >>>[BLABLABLA]
> > > >>>
> > > >>
> > > >>Let's wait another 5 months to commit this.
> > > >
> > > >If it take you soo much pain to fix some space here and there then
> > > >yes it will take that time.
> > > 
> > > IMHO this should not block the filter out of svn.
> > > Fixing documentation, nitpicks about alignment can be done
> > > afterwards and can be done by people caring about it.
> > > 
> > > Regarding the patch, I don't want to use "inlink" for a variable
> > > name, "link" is fine with me.
> > > 
> > > There is no point bike-shedding about this, nor to start a fight.
> > 
> > Feel free to discard the nits and I'll fix them when in SVN, but don't
> > miss the structural changes I pointed out.
> 
> I agree with both of you :)
> Some of stefanos comments are good ideas (i do like the inlink name change for
> example though iam perfectly fine with leaving it named link if baptiste prefers)
> but none of the comments except a missing GPL dep in configure is
> reason to delay commiting this.

And of course I won't oppose such commit, consider like a matter of
personal courtesy to fix those nits or don't.
-- 
FFmpeg = Freak & Free MultiPurpose Encoding/decoding Glue