[FFmpeg-devel] [RFC] switch to poll()

[Luca Barbato]

On 11/24/2010 12:14 AM, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Nov 23, 2010 at 5:44 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
>> On 11/23/2010 09:00 PM, Ronald S. Bultje wrote:
>>> Please resubmit the latest as a single patch. ;-).
>>
>> Here the squashed commit with also rtspenc that was missing.
> [..]
>> +                p[max_p].fd = url_get_file_handle(rtsp_st->rtp_handle);
>> +                p[max_p++].events = POLLIN;
>> +                p[max_p].fd = rtp_get_rtcp_file_handle(rtsp_st->rtp_handle);
>> +                p[max_p++].events = POLLIN;
> 
> Please vertically align. OK otherwise.
> 
>> +                p[max_p].fd =
rtp_get_rtcp_file_handle(rtsp_st->rtp_handle);

would be over 79cols, I'd keep it as it (and fix the POLLOUT -> POLLIN)
and commit if nobody is against this.

lu

PS: could we add a define select -> "please don't use select" like we
have for printf and such?

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero