[FFmpeg-devel] [PATCH 6/6] Add rotate90 filter.

[Ramiro Polla]

On Tue, Nov 23, 2010 at 10:26 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Tuesday 2010-11-23 18:46:17 -0500, Ronald S. Bultje encoded:
>> On Tue, Nov 23, 2010 at 6:34 PM, Stefano Sabatini
>> <stefano.sabatini-lala at poste.it> wrote:
>> > On date Tuesday 2010-11-23 15:18:14 -0800, Baptiste Coudurier encoded:
>> >> On 11/23/2010 12:29 PM, Stefano Sabatini wrote:
>> > [...]
>> >> What's wrong with the rotate filter ?
>> >
>> > overkill for just rotating by 90 degrees (and slower).
>>
>> So integrate this as an optimization in that filter.
>
> That's actually a good idea, but I was thinking about the rotate
> filter like something a bit more general, which should take:
> angle_expr:output_size:padding_color
>
> the rotate90 is just simpler and does what the 95% of the users need
> (and I want to take some time to actually study the algorithms for
> spatial transform of that kind), that's why I thought that having two
> separate filters may be a good idea, and would let us to deliver the
> simple filter *now*.

Why the rush? An optimization to the rotate filter seems like a better
path to me too.