[FFmpeg-devel] [PATCH 2/2] id3v2: add TDTG<->creation_time tag mapping

[Anton Khirnov]

On Mon, Nov 22, 2010 at 11:18:58PM +0100, Aurelien Jacobs wrote:
> On Mon, Nov 22, 2010 at 08:22:35AM +0100, Anton Khirnov wrote:
> > ---
> >  libavformat/id3v2.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
> > index cc3697a..b730265 100644
> > --- a/libavformat/id3v2.c
> > +++ b/libavformat/id3v2.c
> > @@ -277,6 +277,7 @@ const AVMetadataConv ff_id3v2_metadata_conv[] = {
> >      { "TCOP", "copyright"},
> >      { "TDRL", "date"},
> >      { "TDRC", "date"},
> > +    { "TDTG", "creation_time"},
> >      { "TENC", "encoded_by"},
> >      { "TEN",  "encoded_by"},
> >      { "TIT2", "title"},
> 
> I'm not really sure in practice how those tags are used but I wonder
> if creation_time wouldn't map better to TDRC or TDEN than to TDGT...
> 
> Except that, the patch looks obviously OK.
>
TDRC is all about the work, not the file; but TDEN might really be a
better choice.

applied with TDEN

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101123/297c5c58/attachment.pgp>