[FFmpeg-devel] [PATCH] FLAC parser

[Justin Ruggles]

On 11/15/2010 04:31 PM, Michael Chinen wrote:

> Hi,
> 
> On Thu, Nov 11, 2010 at 1:05 AM, Justin Ruggles
> <justin.ruggles at gmail.com> wrote:
>> Hi,
>>
>> Michael Chinen wrote:
>>> +    if (s->flags & PARSER_FLAG_COMPLETE_FRAMES) {
>>> +        FLACFrameInfo fi;
>>> +        if (frame_header_is_valid(avctx, buf, &fi))
>>> +            avctx->frame_size = fi.blocksize;
>>> +        *poutbuf      = buf;
>>> +        *poutbuf_size = buf_size;
>>> +        return buf_size;
>>> +    }
>>
>>
>> Right now the matroska demuxer sets
>> st->need_parsing = AVSTREAM_PARSE_HEADERS;
>> So this part will be executed for matroska packets if the FLAC parser is
>> enabled.
> 
> I don't know much about matroska.  Is this desired?
> 
> I'm waiting on the AV_LOG_MAX bit before attaching.
> 
> Michael
> 
> 
>>
>> Maybe we should consider adding that to other demuxers that can handle
>> FLAC.  This could be done later though.  I just thought I would bring it up.


I don't know much about Matroska, but I would guess that the timestamps
would be adequate, thus the header parsing shouldn't be needed.  Ogg is
another story though...  In theory it should be ok, but I've seen some
screwy things done with Ogg timestamps.

-Justin