[FFmpeg-devel] [PATCH] adpcm: Reset the ssd back to zero more often

[Michael Niedermayer]

On Sat, Nov 20, 2010 at 08:59:25AM +0200, Martin Storsj? wrote:
> On Sat, 20 Nov 2010, Michael Niedermayer wrote:
> 
> > On Thu, Nov 18, 2010 at 04:01:31PM +0200, Martin Storsjo wrote:
> > > If using very large trellis sizes (e.g. -trellis 15), the frontier
> > > is so large that the difference between the best and the worst
> > > trellis node in the frontier is large enough to cause wraparound.
> > > 
> > 
> > > Resetting at (1<<20) is enough to avoid the issue at -trellis 16
> > 
> > have you come to this conclusion by proof or by simply changing the
> > threshold and seeing no problems?
> 
> By changing the threshold until there were no more problems with that 
> particular sample - sorry, I should have mentioned that.
> 
> I think it can't be proven how often it needs to be reset. In the worst 
> pathological case, the best trellis node has ssd 0 while the worst one has 
> a ssd of 65535*65535 added in each generation, overflowing even if we'd 
> subtract the best node's ssd each round.
> 
> The attached patch should avoid the issue properly regardless of how 
> pathologically bad case it is, giving a small but tolerable slowdown. Do 
> you think that is enough, or should that one be combined with this 
> previous patch, resetting it to 0 more often (or perhaps even every round) 
> to avoid this issue happening at all?

have you tried to change ssd to 64bit ?
maybe its faster

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101120/05341dc0/attachment.pgp>