[FFmpeg-devel] [PATCH] *alloc(type)

[Michael Niedermayer]

On Fri, Nov 19, 2010 at 08:28:15PM -0800, Alex Converse wrote:
> On Fri, Nov 19, 2010 at 7:37 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > Hi
> >
> > patchset below fixes the type used in malloc and co
> > The sense behind this patch is that feeding things that dont fit in unsigned
> > int into *alloc() can lead to successfull allocation of too small arrays which
> > is pretty bad.
> 
> Is there somewhere this actually happens?

cmdutils.c read_file()
there might be others


> 
> What happens when what we are trying to allocate something that is
> bigger than size_t? size_t can be as small as 16-bits according to
> c99.

i dont think ffmpeg works on systems with 16bit address space
but i see your point, do platforms where int is bigger than size_t exist?
if not then this is at least not worse than before


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101120/5787a097/attachment.pgp>