[FFmpeg-devel] [PATCH] make mpeg12 decoder return error if error concealment is not set.

[Michael Niedermayer]

On Fri, Nov 19, 2010 at 07:08:38PM -0800, Baptiste Coudurier wrote:
> On 11/19/2010 06:49 PM, Michael Niedermayer wrote:
>> On Thu, Nov 18, 2010 at 05:11:41PM -0800, Baptiste Coudurier wrote:
>>> Hi
>>>
>>> $subject.
>>>
>>> --
>>> Baptiste COUDURIER
>>> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
>>> FFmpeg maintainer                                  http://www.ffmpeg.org
>>
>>>   mpeg12.c |   16 ++++++++++++----
>>>   1 file changed, 12 insertions(+), 4 deletions(-)
>>> eaf1078fa6d06bea7886f11493fe36075e9cf8c2  mpeg2_decoder_error.patch
>>
>> This would result in worse vissual output in mpeg2 or sliced mpeg1 because
>> later slices are completely skiped even if they are correct.
>> And this also will affect future frames negatively
>
> Well, user asked for 0 error concealment, we shouldn't do it anyway.
>
> I want to be able to fail if the frame is damaged, what do you propose ?

error_concealment=-1 maybe

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101120/063086ea/attachment.pgp>