[FFmpeg-devel] [PATCH] overlay filter

[Michael Niedermayer]

On Thu, Nov 18, 2010 at 04:19:45PM -0800, Baptiste Coudurier wrote:
> Hi Stefano,
>
> On 11/15/2010 04:08 AM, Stefano Sabatini wrote:
>> On date Friday 2010-11-12 15:12:06 +0100, Stefano Sabatini encoded:
>>> On date Friday 2010-11-12 13:36:46 +0100, Stefano Sabatini encoded:
>>>> On date Friday 2010-07-16 13:29:42 -0700, Baptiste Coudurier encoded:
>>>>> On 07/16/2010 10:02 AM, Stefano Sabatini wrote:
>>>>>> Hi all,
>>>>>> this is a work in progress based on Bobby and Baptiste work.
>>>>>>
>>>>>> It's not yet ready for review, I'm sending it here in case someone
>>>>>> wants to have a look at it and/or commenting it.
>>>>>>
>>>>>
>>>>> This filter is _highly_ inefficient in this form. Copying the source
>>>>> is useless and can be avoided. Furthermore the timestamps handling
>>>>> is wrong.
>>>>>
>>>>> What you have to do is to handle timestamps correctly in my version.
>>>>
>>>> Done, also this version works with movie-in-movie (but supporting loop
>>>> in movie seems a simple and useful feature anyway).
>>>>
>>>> There is still a bug related to direct rendering (and so only visible
>>>> with ffplay), looking into that
>>> [...]
>>>
>>> Fixed by adding AV_PERM_PRESERVE flag in the rej_perms.
>>
>> Updated with some docs fixes.
>
> Thanks for the work.
>
> Does the filter works to overlay a single picture logo in this form ?
> I believe that's a needed feature and I'll work on this.
>
> Somebody else please review the code, I'd like some comments on the  
> average alpha section for subsampled yuv.

note, i probably wont have the time in the next 3 days to review this.
Also note this is not a request to delay this patch, i dont want to do that ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101119/b72988ce/attachment.pgp>