[FFmpeg-devel] [PATCH] Give sane names to the filters dealing with aspect ratio.

[Michael Niedermayer]

On Fri, Nov 19, 2010 at 01:47:04AM +0100, Stefano Sabatini wrote:
> On date Friday 2010-11-19 01:23:43 +0100, Michael Niedermayer encoded:
> > On Thu, Nov 18, 2010 at 10:33:02PM +0100, Stefano Sabatini wrote:
> > > ---
> > >  libavfilter/Makefile     |    4 ++--
> > >  libavfilter/allfilters.c |    4 ++--
> > >  libavfilter/vf_aspect.c  |   24 ++++++++++++------------
> > >  3 files changed, 16 insertions(+), 16 deletions(-)
> > > 
> > > diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> > > index 71dcf2a..344518c 100644
> > > --- a/libavfilter/Makefile
> > > +++ b/libavfilter/Makefile
> > > @@ -19,7 +19,6 @@ OBJS-$(CONFIG_ANULLSRC_FILTER)               += asrc_anullsrc.o
> > >  
> > >  OBJS-$(CONFIG_ANULLSINK_FILTER)              += asink_anullsink.o
> > >  
> > > -OBJS-$(CONFIG_ASPECT_FILTER)                 += vf_aspect.o
> > >  OBJS-$(CONFIG_BLACKFRAME_FILTER)             += vf_blackframe.o
> > >  OBJS-$(CONFIG_CROP_FILTER)                   += vf_crop.o
> > >  OBJS-$(CONFIG_CROPDETECT_FILTER)             += vf_cropdetect.o
> > > @@ -33,8 +32,9 @@ OBJS-$(CONFIG_NULL_FILTER)                   += vf_null.o
> > >  OBJS-$(CONFIG_OCV_SMOOTH_FILTER)             += vf_libopencv.o
> > >  OBJS-$(CONFIG_PAD_FILTER)                    += vf_pad.o
> > >  OBJS-$(CONFIG_PIXDESCTEST_FILTER)            += vf_pixdesctest.o
> > > -OBJS-$(CONFIG_PIXELASPECT_FILTER)            += vf_aspect.o
> > >  OBJS-$(CONFIG_SCALE_FILTER)                  += vf_scale.o
> > > +OBJS-$(CONFIG_SETDAR_FILTER)                 += vf_aspect.o
> > > +OBJS-$(CONFIG_SETPAR_FILTER)                 += vf_aspect.o
> > 
> > PAR is ambigous, please use SAR (sample aspect ratio), its also what mpeg2 uses
> 
> I prefer "pixel" over "sample" because it is more specific, but I
> won't bikeshed on that, provided that we'll be consistent
> (e.g. dump_format() currently shows DAR/PAR).

P is as much picture as pixel and SAR is a standard term and
grep sample_aspect {*/,}*.c |wc
    138     582   12168
grep pixel_aspect {*/,}*.c |wc
     26     109    2303


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101119/68e7a25f/attachment.pgp>