[FFmpeg-devel] [RFC] switch to poll()

[Luca Barbato]

On 11/16/2010 12:33 AM, Martin Storsj? wrote:
> On Tue, 16 Nov 2010, Martin Storsj? wrote:
> 
>> On Mon, 15 Nov 2010, Luca Barbato wrote:
>>
>>>> Do you want me to test run some of the modified codepaths that you haven't 
>>>> tested yourself, e.g. SAP?
>>>
>>> Yes please
>>
>> Ok, will do.
> 
> The two attached patches need to be squashed into this, then after that, 
> it seems to work fine with both RTSP and SAP.
> 
> The bug with max_p not being reinitialized was particularly nasty - it 
> lead to kernel panics on OS X, when poll was fed with too long pollfd 
> list. (Not sure at which point it happened though, if the bug was due to 
> the kernel reading out of bounds, or if it just was "too many"...)

I wonder why I didn't notice it before =\ shame on me =P

Regarding moving out the for the initialization code, I think it should
be done.

lu


-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero