[FFmpeg-devel] [PATCH 2/3] lavd/utils: always look at file extension when probing

[Anton Khirnov]

On Fri, Nov 12, 2010 at 07:15:17PM +0100, Michael Niedermayer wrote:
> On Fri, Nov 12, 2010 at 06:18:10PM +0100, Anton Khirnov wrote:
> > ---
> >  libavformat/utils.c |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> rejected
> this can (and i wager a bet it will) break things.
what would it break?
> and you provide no example that it fixes so its same or worse than svn
This is related to the issue i mentioned before -- files with huge id3v2
headers fail to be detected if the buffer isn't large enough. Yes i know
the solution is to provide a bigger buffer, but IMO lavf should do the
best possible guess with the information it has and that includes the
file extension.

Anyway, if you're dead set against using file extensions, why are they
even there?

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101113/aaeeedeb/attachment.pgp>