[FFmpeg-devel] [PATCH] Make avfiltergraph.h public.

[Michael Niedermayer]

On Fri, Nov 12, 2010 at 03:36:13PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2010-11-09 02:31:06 +0100, Michael Niedermayer encoded:
> > On Mon, Nov 08, 2010 at 03:34:22PM +0100, Stefano Sabatini wrote:
> > > On date Monday 2010-11-08 15:18:41 +0100, Michael Niedermayer encoded:
> > > > On Sun, Nov 07, 2010 at 11:56:43PM +0100, Stefano Sabatini wrote:
> > > > > On date Thursday 2010-11-04 22:08:53 +0100, Stefano Sabatini encoded:
> > > > > > On date Thursday 2010-10-21 01:32:24 +0200, Michael Niedermayer encoded:
> > > > > > > On Sun, Oct 17, 2010 at 08:34:45PM +0200, Stefano Sabatini wrote:
> > > > > > > > ---
> > > > > > > >  libavfilter/Makefile |    2 +-
> > > > > > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > > > > 
> > > > > > > > diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> > > > > > > > index a00c1a2..f7316cb 100644
> > > > > > > > --- a/libavfilter/Makefile
> > > > > > > > +++ b/libavfilter/Makefile
> > > > > > > > @@ -4,7 +4,7 @@ NAME = avfilter
> > > > > > > >  FFLIBS = avcodec avcore avutil
> > > > > > > >  FFLIBS-$(CONFIG_SCALE_FILTER) += swscale
> > > > > > > >  
> > > > > > > > -HEADERS = avfilter.h
> > > > > > > > +HEADERS = avfilter.h avfiltergraph.h
> > > > > > > 
> > > > > > > Not possible yet because AVFilterGraph cannot be allocated except by using
> > > > > > > sizeof() and that makes it a ABI timebomb
> > > > > > 
> > > > > > Fixed by the addition of avfilter_graph_alloc().
> > > > > 
> > > > > Ping.
> > > > 
> > > > there are several functions moved into the public api that are unused outside
> > > > libavfilter, what are they good for?
> > > 
> > > All the functions in avfiltergraph.h look useful for an application.
> > 
> > do you have a usecase?
> > If not i think you should not propose by patch to make them part of the public
> > API
> > 
> > 
> > > 
> > > Also of which public functions are you talking?,
> > 
> > the ones that are unused. You should know which that are as you are proposing
> > to make them part of the public API.
> > I think its not all that great of an idea to just make headers public headers
> > witghout knowing what part of it is used from outside at all
> > 
> > avfilter_graph_config_links() is one of them btw
> > 
> > 
> > And about it being usefull its not even documented sufficiently to be useable
> > 
> > 
> > > avfiltergraph.h has
> > > always been a private header.
> > 
> > and some of its functions have always been used from outside IIRC
> 
> Check patch.
> -- 
> FFmpeg = Fast and Fast Magical Perennial Ecumenical God

>  avfiltergraph.c |   13 +++++++------
>  avfiltergraph.h |   27 +++------------------------
>  internal.h      |   23 +++++++++++++++++++++++
>  3 files changed, 33 insertions(+), 30 deletions(-)
> 69dc34f1cf8e1270b0413156461782b60f6fd0d0  0002-Prefix-with-ff_-the-functions.patch
> From 9adfc96b50d5571c5922afe812be896a66b6cec8 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Fri, 12 Nov 2010 15:29:12 +0100
> Subject: [PATCH 2/4] Prefix with "ff_" the functions:
>  ff_avfilter_graph_check_validity()
>  ff_avfilter_graph_config_links()
>  ff_avfilter_graph_config_formats()
> 
> and move their declaration to internal.h. These functions are never
> used in application code, so it is better to consider them internal
> functions, this can be changed later if necessary. Simplify API.

ok

[.,..]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101112/2c998308/attachment.pgp>