[FFmpeg-devel] [PATCH] adpcm: Store trellis nodes in a heap structure

[Reimar Döffinger]

On Wed, Nov 10, 2010 at 10:58:12PM +0200, Martin Storsj? wrote:
> On Wed, 10 Nov 2010, Reimar D?ffinger wrote:
> 
> > On Wed, Nov 10, 2010 at 11:42:48AM +0200, Martin Storsj? wrote:
> > > So, another argument for patch #4 is that even if it theoretically should 
> > > give worse results (which it for some reason doesn't, in these tests), it 
> > > speeds up the encoding so much that you can use a larger trellis size, 
> > > giving even better results.
> > 
> > That argument would be a bit more convincing to me if it was possible to
> > set the trellis size larger than 8, the 22 seconds it takes after the patch
> > are hardly insane :-).
> 
> You actually can set the trellis parameter up to 16, making it really 
> insanely slow. Set to 12, it's about 13 times slower than realtime - I 
> don't even want to think about how slow it would be at the higher levels 
> :-)

In that case, do you feel like finding some setting that with all patches is
about the same speed as without patches and compare the quality?
IMO that would possibly be the most interesting comparison.