[FFmpeg-devel] [PATCH] Google WebP support

[Michael Niedermayer]

On Thu, Oct 28, 2010 at 11:22:36AM -0700, Pascal Massimino wrote:
> Ronald,
> 
> On Thu, Oct 28, 2010 at 5:14 AM, Ronald S. Bultje <rsbultje at gmail.com>wrote:
> 
> > Hi,
> >
> > On Thu, Oct 28, 2010 at 1:17 AM, Pascal Massimino
> > <pascal.massimino at gmail.com> wrote:
> > > On Tue, Oct 19, 2010 at 10:34 AM, Pascal Massimino <
> > > pascal.massimino at gmail.com> wrote:
> > >
> > >> Aurelien,
> > >>
> > >> On Tue, Oct 19, 2010 at 4:30 AM, Aurelien Jacobs <aurel at gnuage.org>
> > wrote:
> > >>
> > >>> On Mon, Oct 18, 2010 at 07:39:40PM -0700, Pascal Massimino wrote:
> > >>> > [...]
> > >>> >
> > >>> > About the other webpdec.c/webpenc.c: metadata now seem to no longer
> > >>> works.
> > >>> > AVMetadataConv have been deprecated just after i finished addiung
> > them.
> > >>> > Should i come back to manually mapping tag/metadata keys? (pretty
> > much
> > >>> > like AVMetadataConv was doing?)
> > >>>
> > >>> No. It is not deprecated. It has been moved to internal API. So now,
> > >>> your demuxer has to call ff_metadata_conv() by itself, instead of
> > >>> exporting the conversion table in AVInputFormat. That's the only change
> > >>> required.
> > >>>
> > >>
> > >> actually, i don't need to change stream->metadata to use native tag
> > (since
> > >> i'd need to convert back to generic down the line afterward. And it's
> > just
> > >> about
> > >> putting the tags on the wire so i shouldn't change the object's generic
> > tag
> > >> i'd say).
> > >> $attached?
> > >>
> > >>
> > > ping? does someone want the webp{enc,dec}.c patch? [ ] yes   [ ] no
> >
> > I personally thought that your later img2.c version was much cleaner,
> > regardless of the few extra ifs. It's smaller and works for -i
> > bla%02d.webp input strings. What was the reason you didn't continue
> > that one?
> >
> 
> well, if i submit the change in img2.c, it's take precedence when handling
> .webp image and then i'll lose the ability to handle metadata (and it's also

Let me try to summarize how it looks from my point of view, subjective that
may be
you want metadata to work with webp
image formats in libav* current dont support metadata
so you want to implement webp as something else than a image format
thats looking like a really ugly hack to me.
jpeg has metadata too and we want to support that and with sequences of
jpeg images too, thus whichever way metadata is handled should work for jpeg
sequences ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101110/e99daec6/attachment.pgp>