[FFmpeg-devel] [PATCH 1/4] Implement avfilter_ref_video_buffer().

[Stefano Sabatini]

On date Tuesday 2010-11-09 19:39:16 +0100, Michael Niedermayer encoded:
> On Sat, Nov 06, 2010 at 11:09:05PM +0100, Stefano Sabatini wrote:
> > ---
> >  libavfilter/avfilter.c |   38 +++++++++++++++++++++++++++++++++++++
> >  libavfilter/avfilter.h |   14 +++++++++++++
> >  libavfilter/defaults.c |   49 ++++++++++++++---------------------------------
> >  3 files changed, 67 insertions(+), 34 deletions(-)
[...]
> > --- a/libavfilter/avfilter.h
> > +++ b/libavfilter/avfilter.h
> > @@ -649,6 +649,20 @@ AVFilterBufferRef *avfilter_get_video_buffer(AVFilterLink *link, int perms,
> >                                            int w, int h);
> >  
> >  /**
> > + * Create a video buffer reference wrapped around an already allocated
> > + * image.
> > + *
> > + * @param data pointers to the planes of the image to reference
> > + * @param linesize linesizes for the planes of the image to reference
> > + * @param perms the required access permissions
> > + * @param w the width of the image in data
> > + * @param h the height of the image in data
> > + * @param format the pixel format of the image in data
> > + */
> > +AVFilterBufferRef *avfilter_ref_video_buffer(uint8_t *data[4], int linesize[4], int perms,
> > +                                             int w, int h, enum PixelFormat format);
> 
> that function name is nothing but bad
> 
> avfilter_given_picture_to_ref() is a random better one

well we have a video buffer and we want a reference from them, and I
wanted something similar to:

avfilter_get_video_buffer()
so
avfilter_ref_video_buffer()

Other ideas:
avfilter_get_video_buffer_ref()
avfilter_get_video_buffer_ref_from_image()
avfilter_get_video_buffer_ref_from_video_buffer()
avfilter_get_ref_from_video_buffer()
...
-- 
FFmpeg = Freak & Fierce Mysterious Picky Elitarian Gospel