[FFmpeg-devel] [PATCH] Make avfiltergraph.h public.

[Michael Niedermayer]

On Mon, Nov 08, 2010 at 03:34:22PM +0100, Stefano Sabatini wrote:
> On date Monday 2010-11-08 15:18:41 +0100, Michael Niedermayer encoded:
> > On Sun, Nov 07, 2010 at 11:56:43PM +0100, Stefano Sabatini wrote:
> > > On date Thursday 2010-11-04 22:08:53 +0100, Stefano Sabatini encoded:
> > > > On date Thursday 2010-10-21 01:32:24 +0200, Michael Niedermayer encoded:
> > > > > On Sun, Oct 17, 2010 at 08:34:45PM +0200, Stefano Sabatini wrote:
> > > > > > ---
> > > > > >  libavfilter/Makefile |    2 +-
> > > > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > > 
> > > > > > diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> > > > > > index a00c1a2..f7316cb 100644
> > > > > > --- a/libavfilter/Makefile
> > > > > > +++ b/libavfilter/Makefile
> > > > > > @@ -4,7 +4,7 @@ NAME = avfilter
> > > > > >  FFLIBS = avcodec avcore avutil
> > > > > >  FFLIBS-$(CONFIG_SCALE_FILTER) += swscale
> > > > > >  
> > > > > > -HEADERS = avfilter.h
> > > > > > +HEADERS = avfilter.h avfiltergraph.h
> > > > > 
> > > > > Not possible yet because AVFilterGraph cannot be allocated except by using
> > > > > sizeof() and that makes it a ABI timebomb
> > > > 
> > > > Fixed by the addition of avfilter_graph_alloc().
> > > 
> > > Ping.
> > 
> > there are several functions moved into the public api that are unused outside
> > libavfilter, what are they good for?
> 
> All the functions in avfiltergraph.h look useful for an application.

do you have a usecase?
If not i think you should not propose by patch to make them part of the public
API


> 
> Also of which public functions are you talking?,

the ones that are unused. You should know which that are as you are proposing
to make them part of the public API.
I think its not all that great of an idea to just make headers public headers
witghout knowing what part of it is used from outside at all

avfilter_graph_config_links() is one of them btw


And about it being usefull its not even documented sufficiently to be useable


> avfiltergraph.h has
> always been a private header.

and some of its functions have always been used from outside IIRC


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101109/04c8e2ee/attachment.pgp>