[FFmpeg-devel] [PATCH] Make x11grab cursor drawing suck less

[Jason Garrett-Glaser]

On Sun, Nov 7, 2010 at 12:18 AM, Jason Garrett-Glaser
<darkshikari at gmail.com> wrote:
> <rant>
> X11's API provides unsigned image data through a char* pointer.
> X11's API provides unsigned image data through a char* pointer.
> X11's API provides unsigned image data through a char* pointer.
>
> WHAT THE CHRIST?!!
> </rant>
>
> This patch does a variety of things to make x11grab's cursor-drawing suck less.
>
> 1. ?It now works on 24-bit and 32-bit image data, not just 32-bit.
> Previously, it probably broke horribly on 24-bit. However, since I've
> never seen a single bug report about this, I doubt modern X11 actually
> uses anything less...
> 2. ?It now doesn't try to run on 16-bit or PAL8 (making the code
> handle 16-bit or PAL8 would be much outside the scope of this, and
> impossible to test).
> 3. ?It now does proper alpha-blending. ?Cursors with shadows don't
> look like utter crap anymore.
>
> Did I mention I hate X11 with the fury of a thousand suns?
>
> Dark Shikari
>

And yes I will fix the tabs when I commit; I don't have a real linux
box so I had to steal some random one to test and finalize this, so
vim infiltrated my patch and inserted tabs into it.

Dark Shikari