[FFmpeg-devel] [RFC] Need an additional maintainer rule when deprecating functions [PATCH]

[Michael Niedermayer]

On Fri, Nov 05, 2010 at 03:48:40PM +0100, Cyril Russo wrote:
>
>
>> I agree that that deprecation was a little premature, and
>> documentation should be more complete (especially with regard to the
>> srcFilter and dstFilter params), anyway if you're already familiar
>> with the FFmpeg API ist use should be quite obvious (also as you're a
>> developer so you can read the source and patches are welcome).
>>
>> Also we're having some issues into updating the API, indeed the FFmpeg
>> code is still using the old API, so it will take some more time before
>> it will be actually dropped, but I'm slightly against to remove the
>> deprecation warning.
> What about this ?
>
> Cheers,
> Cyril

>  avformat.h |    1 +
>  1 file changed, 1 insertion(+)
> ac72415b03d5744fa4f2fdb31e85dfa5a884072b  avformatDeprecatedFix.patch
> Index: ../../../Libraries/Externals/ffmpeg/libavformat/avformat.h
> ===================================================================
> --- ../../../Libraries/Externals/ffmpeg/libavformat/avformat.h  (revision 25671)
> +++ ../../../Libraries/Externals/ffmpeg/libavformat/avformat.h  (working copy)
> @@ -724,6 +726,7 @@
>      char filename[1024]; /**< input or output filename */
>      /* stream info */
>      int64_t timestamp;
> +    /** @deprecated Please use metadata API and specially av_metadata_get with the member name has the key */
>  #if FF_API_OLD_METADATA
>      attribute_deprecated char title[512];

that should be inside the if()
remaining review left to our english experts

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101105/0bab242a/attachment.pgp>