[FFmpeg-devel] [PATCH 5/7] Add single stream LATM/LOAS decoder

[Janne Grunau]

On Tue, Nov 02, 2010 at 01:56:11PM +0000, Carl Eugen Hoyos wrote:
> Janne Grunau <janne-ffmpeg <at> jannau.net> writes:
> 
> > On Fri, Oct 29, 2010 at 12:44:56AM +0200, Janne Grunau wrote:
> > > The decoder is basicly just a wrapper around the AAC decoder.
> > > based on patch by Paul Kendall { paul <?t> kcbbs gen nz }
> > 
> > applied whole patch set, after being ok-ed on irc by Alex after some
> > modifications.
> 
> Thank you for working on this long-standing issue!
> I closed issue 244 after testing
> samples.mplayerhq.hu/samples/ffmpeg-bugs/roundup/issue244/mux2.share.ts.

Thank you for taking care of the issue. I remembered that I should have
looked at roundup after committing.

> Is it expected that every sample (I tried) produces many lines of "Error while
> decoding stream" when decoding LATM? (And I don't mean if it's expected that the
> same error line is overwriting the "Last message repeated" lines many times, but
> if errors have to be expected at all when decoding latm.)

No, it's not. Alex spotted the error, fixed in r25676

> A good example (that also shows errors when using latm_aac in MPlayer) is the
> sample from issue 1891: 000000001180bc60.mpg in
> samples.mplayerhq.hu/samples/ffmpeg-bugs/roundup/issue244/eyetv-h264-dk
> 
> The sample from issue 1462 (gazeta-20090408-1456-aa.ts in
> samples/ffmpeg-bugs/roundup/issue1462/) still fails completely, it works (more
> or less) with mplayer -demuxer mpegts -ac faad

works now with ffmpeg

> (And could somebody comment on issue 1999? It would be nice if FFmpeg could
> output an error or at least some explanation what has to be done is given.)

at least the PMT stream type for the audio stream claims ADTS for the
whole file.

Janne