[FFmpeg-devel] [PATCH] PGS subtitle position

[Mark Goodman]

A second patch is attached.

On Thu, Nov 4, 2010 at 11:04 AM, Mark Goodman <mark.goodman at gmail.com> wrote:
> On Thu, Nov 4, 2010 at 4:20 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Mark Goodman <mark.goodman <at> gmail.com> writes:
>>
>>> Position is present in the presentation segment when the object
>>> number is not zero.
>>
>> [...]
>>
>>> - ? ?block = bytestream_get_byte(&buf);;
>>> - ? ?if (block == 0x80) {
>>
>> Any reason you remove this?
>> (I mean: Is this related to the PGS subtitle position fix or just an unrelated
>> improvement in which case it should be sent separately.)
>
> It's incorrect to look at this byte to decide whether position
> information is present. This byte can be 0x40, the object number can
> be 1, and the position information should be read.
>
>>
>>> - ? ? ? ? * ? ? palette_update_flag (0x80),
>>> - ? ? ? ? * ? ? palette_id_to_use,
>>
>> ...
>>
>>> + ? ? * ? ? palette_update_flag (0x80),
>>> + ? ? * ? ? palette_id_to_use
>>
>> (some more to follow)
>>
>> Please do not re-indent together with functional changes in one patch (make the
>> patch as small as possible, re-indentation should be done in a separate patch).
>
> I'll send another patch.
>
>>
>> Carl Eugen
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at mplayerhq.hu
>> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pgssubdec_position_2.patch
Type: text/x-patch
Size: 1755 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101104/7f40e31c/attachment.bin>