[FFmpeg-devel] [PATCH] PGS subtitle position
Carl Eugen Hoyos
cehoyos
Thu Nov 4 12:20:54 CET 2010
Mark Goodman <mark.goodman <at> gmail.com> writes:
> Position is present in the presentation segment when the object
> number is not zero.
[...]
> - block = bytestream_get_byte(&buf);;
> - if (block == 0x80) {
Any reason you remove this?
(I mean: Is this related to the PGS subtitle position fix or just an unrelated
improvement in which case it should be sent separately.)
> - * palette_update_flag (0x80),
> - * palette_id_to_use,
...
> + * palette_update_flag (0x80),
> + * palette_id_to_use
(some more to follow)
Please do not re-indent together with functional changes in one patch (make the
patch as small as possible, re-indentation should be done in a separate patch).
Carl Eugen
More information about the ffmpeg-devel
mailing list