[FFmpeg-devel] [PATCH 2/5] Remove graphparser.h header, move avfilter_graph_parse() declaration to libavfilter/avfiltergraph.h.

[Michael Niedermayer]

On Tue, Nov 02, 2010 at 09:02:22PM +0100, Stefano Sabatini wrote:
> Simplify and less confusing for the user.
> ---
>  ffmpeg.c                    |    1 -
>  ffplay.c                    |    1 -
>  libavfilter/avfiltergraph.h |   24 +++++++++++++++++++
>  libavfilter/graphparser.c   |    1 -
>  libavfilter/graphparser.h   |   52 -------------------------------------------
>  5 files changed, 24 insertions(+), 55 deletions(-)
>  delete mode 100644 libavfilter/graphparser.h
> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 85ee5bb..159c7be 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -48,7 +48,6 @@
>  #if CONFIG_AVFILTER
>  # include "libavfilter/avfilter.h"
>  # include "libavfilter/avfiltergraph.h"
> -# include "libavfilter/graphparser.h"
>  # include "libavfilter/vsrc_buffer.h"
>  #endif
>  
> diff --git a/ffplay.c b/ffplay.c
> index 581e994..cd175df 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -40,7 +40,6 @@
>  #if CONFIG_AVFILTER
>  # include "libavfilter/avfilter.h"
>  # include "libavfilter/avfiltergraph.h"
> -# include "libavfilter/graphparser.h"
>  #endif
>  
>  #include "cmdutils.h"
> diff --git a/libavfilter/avfiltergraph.h b/libavfilter/avfiltergraph.h
> index 0b08f02..428c531 100644
> --- a/libavfilter/avfiltergraph.h
> +++ b/libavfilter/avfiltergraph.h
> @@ -87,4 +87,28 @@ int avfilter_graph_config(AVFilterGraph *graphctx, AVClass *log_ctx);
>   */
>  void avfilter_graph_destroy(AVFilterGraph *graph);
>  
> +/**
> + * A linked-list of the inputs/outputs of the filter chain.
> + */
> +typedef struct AVFilterInOut {
> +    char *name;
> +    AVFilterContext *filter;
> +    int pad_idx;
> +
> +    struct AVFilterInOut *next;
> +} AVFilterInOut;

This is missing dox and being public it needs dox.
(seperate of this patch of course)

ok otherwise

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101104/943559e9/attachment.pgp>