[FFmpeg-devel] [PATCH 4/4] Fix FFv1 decoder buffer releasing.

Michael Niedermayer michaelni
Wed Nov 3 23:34:08 CET 2010


On Wed, Nov 03, 2010 at 10:28:58PM +0100, Stefano Sabatini wrote:
> Previously it was releasing the buffer which was returned to the user,
> which was resulting in a crash in case of direct rendering.
> ---
>  libavcodec/ffv1.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)

lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101103/8c62aaf8/attachment.pgp>



More information about the ffmpeg-devel mailing list