[FFmpeg-devel] [PATCH] common ID3v2 support for all formats

[Anton Khirnov]

On Fri, Oct 01, 2010 at 08:21:07PM +0200, Reimar D?ffinger wrote:
> Hello,
> considering issue 2258 I think it is a valid conclusion that people
> will prepend a ID3v2 header to anything that can't run aways fast enough
> (and then give it a .mp3 extension...).
> So I propose attached patch that moves that parsing to common code.
> Note that is assume that due to buffering the ID3 parsing attempt
> will not cause any issues even on non-seekable input.
> Note that I have no idea WTF the mpc demuxer code is doing there,
> my conclusion was that it should be safe to just throw it all away,
> but I'm not 100% sure I don't miss some subtlety.
> Mostly unrelated, but one issue with this whole ID3 handling is
> that AFAICT it will use the file-specific metadata conversion
> instead of using always the ID3 one.
This change broke detection of mp3 files with really big id3v2 headers
in MPD, which uses a small 64kb buffer. This is probably MPD's fault,
but perhaps there should be a way for av_probe_input_format to signal
that "the stream looks useful, need more data" -- which would be done e.g.
when an id3 header is found which is bigger than the probe data buffer.

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101103/64ddb2f4/attachment.pgp>