[FFmpeg-devel] [PATCH 2/2] Implement functions: av_get_sample_fmt_name() av_get_sample_fmt() av_get_sample_fmt_string()

[Michael Niedermayer]

On Tue, Nov 02, 2010 at 09:51:59PM +0100, Stefano Sabatini wrote:
> On date Monday 2010-11-01 14:45:01 +0100, Michael Niedermayer encoded:
> > On Fri, Oct 29, 2010 at 12:32:20AM -0700, Stefano Sabatini wrote:
> > > in libavcore, and deprecate the corresponding libavcodec/audioconvert.h functions:
> > > avcodec_get_sample_fmt_name()
> > > avcodec_get_sample_fmt()
> > > avcodec_sample_fmt_string()
> > [...]
> > > +/**
> > > + * Generate a string corresponding to the sample format with
> > > + * sample_fmt, or a header if sample_fmt is negative.
> > > + *
> > > + * @param buf the buffer where to write the string
> > > + * @param buf_size the size of buf
> > > + * @param sample_fmt the number of the sample format to print the
> > > + * corresponding info string, or a negative value to print the
> > > + * corresponding header.
> > > + * Meaningful values for obtaining a sample format info vary from 0 to
> > 
> > > + * AV_SAMPLE_FMT_NB -1.
> >        ^^^^^^^^^^^^
> >        not part of public api
> 
> Removed and patch updated.
> -- 
> FFmpeg = Fancy & Foolish Minimalistic Prodigious Emblematic Gem

>  doc/APIchanges            |    6 ++++
>  libavcodec/audioconvert.c |   36 ++++---------------------
>  libavcodec/audioconvert.h |   19 +++++--------
>  libavcore/Makefile        |    1 
>  libavcore/samplefmt.c     |   64 ++++++++++++++++++++++++++++++++++++++++++++++
>  libavcore/samplefmt.h     |   26 ++++++++++++++++++
>  6 files changed, 111 insertions(+), 41 deletions(-)
> d99a1f2b4f7680b9f516391ea9838bb5210518f2  0001-Implement-functions.patch
> From cbfc427d7b74f4dd5d44d1a13fb36fd2c72b24d3 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Fri, 29 Oct 2010 00:30:36 -0700
> Subject: [PATCH 1/3] Implement functions:
>  av_get_sample_fmt_name()
>  av_get_sample_fmt()
>  av_get_sample_fmt_string()

lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101102/596aaab9/attachment.pgp>