[FFmpeg-devel] [PATCH] Fix bad comment in aac code

[Alex Converse]

On Tue, May 25, 2010 at 2:09 PM, Cyril Russo
<stage.nexvision at laposte.net> wrote:
> Hi
>

Hi,

> Index: libavcodec/aac.c
> ===================================================================
> --- libavcodec/aac.c    (revision 23312)
> +++ libavcodec/aac.c    (working copy)
> @@ -127,8 +127,8 @@
>          }
>      case 6:
>          /* Some streams incorrectly code 5.1 audio as SCE[0] CPE[0] CPE[1] SCE[1]
> -           instead of SCE[0] CPE[0] CPE[0] LFE[0]. If we seem to have
> -           encountered such a stream, transfer the LFE[0] element to SCE[1] */
> +           instead of SCE[0] CPE[0] CPE[1] LFE[0]. If we seem to have
> +           encountered such a stream, transfer the SCE[1] element to LFE[0] */
>          if (ac->tags_mapped == tags_per_config[ac->m4ac.chan_config] - 1 && (type == TYPE_LFE || type == TYPE_SCE)) {
>              ac->tags_mapped++;
>              return ac->tag_che_map[type][elem_id] = ac->che[TYPE_LFE][0];

I think the text is trying to say that we are putting
ac->che[TYPE_LFE][0] into ac->tag_che_map[TYPE_SCE][1].

This is because the "LFE" will be read and looked up as SCE.1 in the bitstream.