[FFmpeg-devel] [PATCH] add md5 muxer

Michael Niedermayer michaelni
Sun May 23 19:38:10 CEST 2010

On Sun, May 23, 2010 at 04:02:38PM +0100, M?ns Rullg?rd wrote:
> Mike Melanson <mike at multimedia.cx> writes:
> > Reimar D?ffinger wrote:
> >> On Sun, May 23, 2010 at 01:38:21PM +0100, M?ns Rullg?rd wrote:
> >>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> >>>
> >>>> Hello,
> >>>> we have -f crc, but IMO 32 bit crc are a bit little for a whole file and
> >>>> also we use md5sum in the regression tests, so I'd propose to add a -f
> >>>> md5 as in attached patch.
> >>> And as usual, people adding so much to the list of requirements that
> >>> nothing at all got done in the end.
> >>>
> >>> Just apply this so we can use it.
> >> Applied.
> >> Attached would extend this by a framemd5 muxer in addition.
> >
> > Whatever happened to the bikeshed arguments regarding whether we
> > should also support some variant of SHA?
> We decided to ignore them.  If people want that, they can send their
> own patches.

i agree with this patch being applied
i dont agree to ignoring review comments though, one should at least
attempt to politely ask the person commenting first. Chances are
one would quickly find a solution if the comment really went too far
which it did in this case.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100523/8ab3fad6/attachment.pgp>

More information about the ffmpeg-devel mailing list