[FFmpeg-devel] [PATCH] Make ff_url_split() and ff_url_join() public.

[Martin Storsjö]

On Sun, 23 May 2010, Stefano Sabatini wrote:

> On date Sunday 2010-05-23 13:11:56 +0300, Martin Storsj? encoded:
> > On Sat, 22 May 2010, Stefano Sabatini wrote:
> > 
> > > ---
> > >  libavformat/avformat.h  |   45 ++++++++++++++++++++++++++++++++++++++++++++
> > >  libavformat/internal.h  |   42 +++-------------------------------------
> > >  libavformat/rtmpproto.c |    4 +-
> > >  libavformat/utils.c     |   48 +++++++++++++++++++++++++++++++++++++++++-----
> > >  4 files changed, 93 insertions(+), 46 deletions(-)
> > 
> > Looks sensible to me in general. Please wait for a go or no-go from at 
> > least Ronald, too. Some comments below:
> [...]
> 
> All issues addressed, I removed the ff_url_join() function, and moved
> declaration for ff_url_split() to utils.c.

Looks good to me.

> There is yet a problem to be addressed to commit this
> change. ff_url_join() requires ff_network_init() to be called:
> 
>  * Note, this requires networking to be initialized, so the caller
>  * must ensure ff_network_init() has been called.
> 
> Should we make ff_network_init() public as well?

Hmm, I'm not sure. I'm not sure what to do with this, perhaps make only 
url_split public but refrain from making url_join public?

// Martin