[FFmpeg-devel] [PATCH] fix unconditional H264 references to SVQ3

[Howard Chu]

Carl Eugen Hoyos wrote:
> Howard Chu<hyc<at>  highlandsun.com>  writes:
>
>> Even though there's a configure flag for SVQ3, these references weren't
>> honoring it.
>
> No.
>
>> Fixed by this patch.
>
> Please provide the error message or nm output.

The error occurred at link time, when compiling with optimization turned off.
Without the patch:

CC	libavcodec/h264.o
/home/software/ffmpeg/libavcodec/h264.c: In function 'fill_filter_caches':
/home/software/ffmpeg/libavcodec/h264.c:2309: warning: initialization from 
incompatible pointer type
/home/software/ffmpeg/libavcodec/h264.c:2386: warning: initialization from 
incompatible pointer type
/home/software/ffmpeg/libavcodec/h264.c:2401: warning: initialization from 
incompatible pointer type
AR	libavcodec/libavcodec.a
LD	ffserver_g
/home/software/ffmpeg/android/libavcodec/libavcodec.a(h264.o): In function 
`hl_decode_mb_internal':
/home/software/ffmpeg/libavcodec/h264.c:1220: undefined reference to 
`ff_svq3_add_idct_c'
/home/software/ffmpeg/libavcodec/h264.c:1232: undefined reference to 
`ff_svq3_luma_dc_dequant_idct_c'
/home/software/ffmpeg/libavcodec/h264.c:1280: undefined reference to 
`ff_svq3_add_idct_c'
/home/software/ffmpeg/libavcodec/h264.c:1315: undefined reference to 
`ff_svq3_add_idct_c'
collect2: ld returned 1 exit status
make: *** [ffserver_g] Error 1
violino:/home/software/ffmpeg/android>

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/