[FFmpeg-devel] [PATCH] IFF: Merge lots of duplicate code into a single function

Sebastian Vater cdgs.basty
Sun May 16 18:06:12 CEST 2010

Ronald S. Bultje a ?crit :
> Hi,
> On Fri, May 14, 2010 at 9:48 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
> [..]
>> + * @return returns pointer to the source stream's end of line
> I find the return value a bit iffy, I'd expect it to return bytes
> consumed (and then callers do buf += decodebyterun()). What do others
> think? I don't want to bikeshed over this but just want some input
> from other devs.

Hi Ronald, do you like it better now? I have also added returning
an error if byterun1 is malformed in some way.
Also I forgot to add documentation for buf_end => Fixed.

Besides this, I added Stefano's hint about get_buffer returning err
instead -1 here, since I had to introduce err variable here anyway.

Please review this new one, if it's OK I will adapt HAM patch to this.


Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-function-merge.patch
Type: text/x-patch
Size: 6111 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100516/428dde4b/attachment.bin>

More information about the ffmpeg-devel mailing list