[FFmpeg-devel] [PATCH] fix tools/probetest compilation

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Thu, May 13, 2010 at 04:47:47PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Thu, May 13, 2010 at 01:42:44AM +0200, Janne Grunau wrote:
>> >> Hi,
>> >> 
>> >> tools/probetest uses internal functions and need -DHAVE_AV_CONFIG_H to
>> >> compile. see patch.
>> >
>> > i think it worked without that in the past. Find which commit broke
>> > it please and then lets fix or revert that
>> 
>> It broke when we stopped passing that flag.
>> 
>> > its very very bad if tools use internal API, as people will use it
>> > as example for their applications
>> 
>> Then perhaps you'd like to fix them.
>
> done

At the cost of breaking the build entirely with some compilers.

>> Both probetest and trasher use internal stuff.
>
> trasher doesnt even use anything from libav*

Sorry, I must have misremembered.

-- 
M?ns Rullg?rd
mans at mansr.com