[FFmpeg-devel] [PATCH] IFF: Add grayscale support to decoder

Ronald S. Bultje rsbultje
Mon May 10 18:04:23 CEST 2010


Hi,

On Mon, May 10, 2010 at 12:00 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Ronald S. Bultje a ?crit :
>> On Mon, May 10, 2010 at 11:32 AM, Sebastian Vater
>> <cdgs.basty at googlemail.com> wrote:
>>> + ? ?if (count > 0) { // PIX_FMT_RGB8
>>
>> if (count) { //...
>
> It should really check for just > 0 (is signed)...if we start to play
> later with extradata stuff and have to subtract, it might be get < 0.

Isn't count < 0 a bug?

Ronald



More information about the ffmpeg-devel mailing list